From: Heikki Orsila <shdl@zakalwe.fi>
Date: Tue, 15 Apr 2008 00:43:10 GMT
Subject: Re: [PATCH] Make core.sharedRepository more generic (version 2)
Message-ID: <20080415004310.GI31039@zakalwe.fi>
In-Reply-To: <7v3apo7zfg.fsf@gitster.siamese.dyndns.org>

On Mon, Apr 14, 2008 at 05:08:03PM -0700, Junio C Hamano wrote:
> > +		 * of git. Note, we use octal numbers.
> >  		 */
> > -		sprintf(buf, "%d", shared_repository);
> > +		sprintf(buf, "0%o", shared_repository);
> 
> Unconditionally doing this makes the resulting repository unusable by git
> 1.5.5 and older, even when the user wanted to use the bog standard "git
> init --shared".  You can limit the extent of damage if you continue
> writing PERM_GROUP and PERM_EVERYBODY out as 1 and 2, and use the new
> octal notation only when the user used the settings allowed only with new
> git.

I submitted a new patch that should address all the points.

Heikki