From: Bryan Donlan <bdonlan@fushizen.net>
Date: Thu, 10 Apr 2008 08:48:20 GMT
Subject: Re: [PATCH v2 01/10] git-rebase.sh: Fix --merge --abort failures when path contains whitespace
Message-ID: <20080410084820.GA1904@shion.is.fushizen.net>
In-Reply-To: <7vr6dexids.fsf@gitster.siamese.dyndns.org>

On Thu, Apr 10, 2008 at 12:45:51AM -0700, Junio C Hamano wrote:
> Bryan Donlan <bdonlan@fushizen.net> writes:
[snip]
> > +	test_expect_success "rebase$type --abort" "
> > +		cd \"\$work_dir\" &&
> >  		# Clean up the state from the previous one
> > +		git reset --hard pre-rebase &&
> > +		test_must_fail git rebase$type master &&
> > +		test -d \"\$dotest\" &&
> > ...
> 
> this part would become a lot easier to read if you just stayed inside the
> original single quoted test script without introducing excessive
> backslashes.

Oh, wow, what was I thinking? I'll fix that up... it must've been rather
late at night when I wrote that or something :)

Also, I saw your note about changing the git-svn tests to single-quoting
rather than escaping everywhere - but only after I hit send. I'll roll
that into the v3 (and probably wait longer than this time, so people
have time to finish reviewing...)

Thanks,

Bryan