From: Bryan Donlan <bdonlan@fushizen.net>
Date: Thu, 10 Apr 2008 07:02:46 GMT
Subject: Re: [PATCH 8/8] Fix tests breaking when checkout path contains shell metacharacters
Message-ID: <20080410070246.GA27790@shion.is.fushizen.net>
In-Reply-To: <47FDB85F.9070503@viscovery.net>

On Thu, Apr 10, 2008 at 08:49:03AM +0200, Johannes Sixt wrote:
> Bryan Donlan schrieb:
> > To be honest, I fixed all the git-svn tests with a suitably clever vim s///
> > expression, so at the time this way was actually easier :)
> 
> Fair enough. If you still have the statement in you vim history, it's
> worth quoting in the commit message. It's another piece of information
> that helps reviewing.

It's fallen off by now, but as I recall it was something along the lines
of:
:%s/\$\({a number of questionable variable names}\)/\\"\\$\1\\"/gc

After which point I stepped through the matches to confirm that it was
actually within the test eval strings at the time.

Thanks,

Bryan