From: Jeff King Date: Tue, 01 Apr 2008 11:03:55 GMT Subject: Re: Sending patches via gmail Message-ID: <20080401110355.GA3777@coredump.intra.peff.net> In-Reply-To: <57518fd10804010351x341ba728i69cfcad8f3909d6a@mail.gmail.com> On Tue, Apr 01, 2008 at 11:51:38AM +0100, Jonathan del Strother wrote: > ...which seems to work ok, except for the fact that the From line in > my patch (the output of git format-patch) then appears at the top of > my message body in the resulting email (from git send-email). > Deleting the From line from the patch seems to make everything work as > expected. Any ideas what's going on there? send-email will create a "from" line in the body of the message if the "sender" (using --from, or answering "Who should the emails appear to be from") doesn't match the patch's author (the "From:" line in the generated patch, which comes from the author field of the commit). The line is interpeted by git-am to properly credit the original author. It looks like you are committing as jon.delStrother@bestbefore.tv, but sending the emails as maillist@steelskies.com. -Peff