From: Miklos Vajna <vmiklos@frugalware.org>
Date: Mon, 31 Mar 2008 17:38:02 GMT
Subject: Re: [PATCH] git gc --auto: defer on battery
Message-ID: <20080331173801.GD10018@genesis.frugalware.org>
In-Reply-To: <47F11036.1000809@nrlssc.navy.mil>

On Mon, Mar 31, 2008 at 11:24:22AM -0500, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> Miklos Vajna wrote:
> > This patch modifies git gc --auto so that it will not always repack when
> > a user is on battery.
> > 
> > It introduces the new gc.deferonbattery configuration variable,
> 
> Shouldn't the config option have 'auto' in the name? Or in some way convey
> that this is _only_ about deferring automatic gc'ing?

That makes sense. Though this patch isn't OK, see my other patch series
in this thread (the pre-auto-gc hook has no config name).