From: Michele Ballabio Date: Mon, 24 Mar 2008 21:18:43 GMT Subject: Re: [PATCH 3/2] parse-options.c: introduce OPT_DATE Message-ID: <200803242218.44026.barra_cuda@katamail.com> In-Reply-To: <7vwsnrubmd.fsf@gitster.siamese.dyndns.org> On Monday 24 March 2008, Junio C Hamano wrote: > Michele Ballabio writes: > > > +int parse_opt_approxidate_cb(const struct option *opt, const char *arg, > > +             int unset) > > +{ > > +     *(unsigned int *)(opt->value) = approxidate(arg); > > Doesn't approxidate return ulong, not uint? Yes, you're right.