From: Xavier Maillard <xma@gnu.org>
Date: Sun, 23 Mar 2008 01:00:04 GMT
Subject: Re: [PATCH 1/2] help: use man viewer path from "man.<tool>.path" config var
Message-ID: <200803230100.m2N104Gb025279@localhost.localdomain>
In-Reply-To: <200803210823.47899.chriscool@tuxfamily.org>


   Le jeudi 20 mars 2008, Junio C Hamano a écrit :
   > Christian Couder <chriscool@tuxfamily.org> writes:
   > > Yes, but if the user just wants to use a konq that is not in the path,
   > > then the konq specified with "man.konqueror.path" should behave the
   > > same as when using the konq in the path. That means that we should also
   > > try to open a new tab on an existing konq, and this will not be the
   > > case if we use "/path/konqueror URL" instead of "/path/kfmclient newTab
   > > URL".
   >
   > If that inconsistency bothers you, you probably should rename the
   > built-in konqueror support to "kfmclient", which is more honest approach,
   > I would think.

   It's perhaps more honest, but kfmclient is not as well known as konqueror.

I am not a KDE user at all and it is true that outside from here,
konqueror is a well known program whereas kfmlient is not (by the
way what is exactly kfmclient ?).

   Isn't a documentation patch like this enough:

   ------8<---------

   diff --git a/Documentation/git-help.txt b/Documentation/git-help.txt
   index 4c6cb21..0ece412 100644
   --- a/Documentation/git-help.txt
   +++ b/Documentation/git-help.txt
   @@ -87,7 +87,8 @@ is chosen. Only the following values are currently 
   supported:
    * "man": use the 'man' program as usual,
    * "woman": use 'emacsclient' to launch the "woman" mode in emacs
    (this only works starting with emacsclient versions 22),
   -* "konqueror": use a man KIO slave in konqueror.
   +* "konqueror": use kfmclient to open the man page in a new konqueror
   +tab.

I find this clearer at user point of view than the older entry.

Regards,

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org