From: Jeff King <peff@peff.net>
Date: Tue, 18 Mar 2008 22:44:37 GMT
Subject: Re: [PATCH 03/16] more tr portability test script fixes
Message-ID: <20080318224436.GA6806@coredump.intra.peff.net>
In-Reply-To: <20080318222302.GA3450@steel.home>

On Tue, Mar 18, 2008 at 11:23:02PM +0100, Alex Riesen wrote:

> Jeff King, Wed, Mar 12, 2008 22:31:06 +0100:
> > -    tr '\000' '\012' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
> > -    tr '\000' '\012' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2
> > +    perl -pe 'y/\000/\012/' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
> > +    perl -pe 'y/\000/\012/' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2
> 
> These break in presence of ActiveState Perl on Windows.
> 
> I suggest replacing such simple construction with a simplified,
> in-tree, version of tr.

<sigh> It's sad that it must come to that, but your test-tr patches seem
like the only sane choice. They seem to work fine on my Solaris box.

Note that there are still a few uses of 'tr' in actual git scripts.
However, they are pretty tame, so I think they should work everywhere.
Otherwise, test-tr must become "git tr". :)

-Peff