From: Jeff King <peff@peff.net>
Date: Thu, 13 Mar 2008 12:10:00 GMT
Subject: Re: [PATCH 10/16] add NO_EXTERNAL_GREP build option
Message-ID: <20080313121000.GB19485@coredump.intra.peff.net>
In-Reply-To: <7viqzr4lua.fsf@gitster.siamese.dyndns.org>

On Wed, Mar 12, 2008 at 03:30:05PM -0700, Junio C Hamano wrote:

> Perhaps place
> 
>     #ifndef NO_EXTERNAL_GREP
>     #ifndef __unix__
>     #define NO_EXTERNAL_GREP 1
>     #else
>     #define NO_EXTERNAL_GREP 0
>     #endif
>     #endif
> 
> in git-compat-util.h, and make the in-code reference to
> 
>     #if NO_EXTERNAL_GREP
>             ... optimization using external grep ...
>     #endif

I agree that is much nicer. Looks like you have already marked it up in
pu; what is there looks sane.

-Peff