From: Adeodato Simó Date: Fri, 07 Mar 2008 09:25:44 GMT Subject: Re: [PATCH] unquote_c_style: fix off-by-one. Message-ID: <20080307092544.GA22069@chistera.yi.org> In-Reply-To: <20080307004401.GA13642@artemis.madism.org> * Pierre Habouzit [Fri, 07 Mar 2008 01:44:01 +0100]: > On Thu, Mar 06, 2008 at 10:10:41PM +0000, Junio C Hamano wrote: > > Pierre Habouzit writes: > > > Thanks to Adeodato Simò for having caught this. > > > Signed-off-by: Pierre Habouzit > > Thanks. I would have appreciated a comment that said something about what > > external breakages this one caused, so that we can have an entry in "bugs > > fixed" list. > > A quick audit of the existing callers suggests that it is fast-import. Yes, it's fast-import. In particular, trying to rename a file whose name contains spaces: R "file 1.txt" file 2.txt ^ unquote_c_style() eats that space, thus fast-import fails with: fatal: Missing space after source: R "file 1.txt" file 2.txt Cheers, -- Adeodato Simó dato at net.com.org.es Debian Developer adeodato at debian.org - In Italy, for 30 years under the Borgias they had warfare, terror, murder, bloodshed, but they produced Michelangelo, Leonardo da Vinci, and the Renaissance. In Switzerland they had brotherly love - they had 500 years of democracy and peace, and what did that produce? The cuckoo clock. -- Harry Lime in “The Third Man”