From: Johan Herland <johan@herland.net>
Date: Wed, 05 Mar 2008 23:56:27 GMT
Subject: Re: [PATCH] Add test for cloning with "--reference" repo being a subset of source repo
Message-ID: <200803060056.27288.johan@herland.net>
In-Reply-To: <alpine.LNX.1.00.0803041922090.19665@iabervon.org>

On Wednesday 05 March 2008, Daniel Barkalow wrote:
> On Tue, 4 Mar 2008, Daniel Barkalow wrote:
> > I think we should be able to avoid setting git_dir to anything other than 
> > the repo we're creating, which would avoid this problem for the present, 
> > although, as you say, it would be good to be able to switch around as 
> > instructed for libification purposes eventually.
> 
> Okay, stuff pushed out to not use git_dir to access the reference repo, 
> and an additional test that requires that we actually note that we have 
> the refs in the reference repository (because otherwise we could pass all 
> the tests by just making --reference useless, but that's obviously no 
> good).

Thanks. Nice work. The testsuite passes, and it all looks good from here. :)


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net