From: Shawn O. Pearce Date: Wed, 05 Mar 2008 05:56:59 GMT Subject: Re: [PATCH v2 3/3] Teach git-fetch to exploit server side automatic tag following Message-ID: <20080305055659.GD8410@spearce.org> In-Reply-To: Johannes Schindelin wrote: > just two comments from me for this patch series: > > - it's a beaut, and Thanks. > - should followtags not be the default? No. Absolutely not. The client may not want tag objects from this remote. It might not want those tags for all sorts of reasons. Maybe they are doing a one-shot pull. Maybe they don't trust this remote. Maybe they trust this remote but this remote is famous for 192M tags containing PDFs of photo images of build logs printed out on paper, then photographed on a wood table and finally scanned in at 600 dpi. So it should only be enabled *if* we were willing to open a second connection to this remote to followtags from it. And that's not a change from prior behavior either, its just faster. -- Shawn.