From: Shawn O. Pearce Date: Wed, 05 Mar 2008 05:12:12 GMT Subject: Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin Message-ID: <20080305051212.GZ8410@spearce.org> In-Reply-To: <0tr6eq87az.wl%bremner@pivot.cs.unb.ca> David Bremner wrote: > >>>>> "Johannes" == Johannes Schindelin writes: > > >> Tue, 4 Mar 2008, David Bremner wrote: > >> > >> Yeah, I should have been more explicit. The problem is a line > >> > >> read -N1 VAR > > Johannes> Can you be even more explicit? IOW why does this have > Johannes> to be a pre-commit hook, and cannot be done before > Johannes> calling git-commit itself? > > I have this feeling I don't really understand the question. Yes, in > principle, whatever I am doing in a pre-commit hook could be done by > hand first. I guess it is primarily a user interface issue. The goal > is modify the behaviour of git-commit in a particular repository; > isn't this the purpose of pre-commit hooks? What happens to such hooks under git-gui? git-gui invokes the pre-commit hook with stdin coming off the stdin that the wish process inherited when it was spawned. This may not be the best way to interact with the end-user of that repository. -- Shawn.