From: Wayne Davison Date: Tue, 04 Mar 2008 23:51:31 GMT Subject: Re: [PATCH] Add compat/vsnprintf.c for systems that returns -1 on maxsize reached Message-ID: <20080304235131.GA27590@herod.dreamhost.com> In-Reply-To: <47CD78C9.80003@viscovery.net> On Tue, Mar 04, 2008 at 05:28:57PM +0100, Johannes Sixt wrote: > But there is also another complication: The size parameter of the system's > vsnprintf must not count the trailing NUL, i.e. the buffer must actually > have space for one extra byte, whereas the POSIX version must count NUL. FYI, rsync's configure script has a check for both those problems. It sets HAVE_C99_VSNPRINTF if vsnprintf() works right. If that fails, rsync uses its own lib/snprintf.c implementation (that I believe comes from Samba). That file could be included in git, if desired. ..wayne..