From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 03 Mar 2008 07:33:07 GMT
Subject: Re: [PATCH] Redirect stderr to a pipe before redirecting stdout to stderr
Message-ID: <20080303073307.GG8410@spearce.org>
In-Reply-To: <20080303082111.24d3ea73.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> wrote:
> With this patch, in the 'start_command' function after forking
> we now take care of stderr in the child process before stdout.
> 
> This way if 'start_command' is called with a 'child_process'
> argument like this:
> 
> 	.err = -1;
> 	.stdout_to_stderr = 1;
> 
> then stderr will be redirected to a pipe before stdout is
> redirected to stderr. So we can now get the process' stdout
> from the pipe (as well as its stderr).

I'm in favor of this patch.  My series to add sideband support
to send-pack/receive-pack (aka push) needed it for the hooks.

-- 
Shawn.