From: Pierre Habouzit Date: Sun, 02 Mar 2008 08:11:40 GMT Subject: Re: [PATCH] convert shortlog to use parse_options Message-ID: <20080302081139.GA5407@artemis.madism.org> In-Reply-To: <20080302061541.GA3935@coredump.intra.peff.net> On Sun, Mar 02, 2008 at 06:15:42AM +0000, Jeff King wrote: > #define OPT__REVISION(x) \ > OPT_BOOLEAN(0, "no-merges", &(x)->no_merges, "don't show merges"), > OPT_BOOLEAN(0, "boundary", &(x)->boundary, "show boundary commits"), > ... > > and we could have unified options tables. I seem to recall some work > being done in this area early on in the parse-options history, but I > can't seem to find any mention of it in the list archive. Pierre, does > this ring a bell? Yes, I didn't had the time to finish that, I just started some ground works in the diff options area, I hope I didn't lost that work, it's probably somewhere on my public repository. Though revision parsing are special because of --not, but I think the proper solution wrt --not and --all in revision parsing is to ask parse-opt to "let" some options stay as arguments, and do the final revision parsing with them kept. Like you may have noticed, I didn't have a lot of time for git recently, and that's a shame :| But maybe your mail will beat me into working on this again now that 1.5.4 is released, because I also feared that reworking diff and revision parsing options will probably introduce quite a few regressions, and it's rather better doing so at the beginning of a release cycle :) -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org