From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Thu, 28 Feb 2008 21:12:02 GMT
Subject: Re: [PATCH 33/40] When installing, be prepared that template_dir may be relative.
Message-ID: <200802282212.02683.johannes.sixt@telecom.at>
In-Reply-To: <alpine.LSU.1.00.0802281542000.22527@racer.site>

On Thursday 28 February 2008 16:45, Johannes Schindelin wrote:
> Hi,
>
> On Wed, 27 Feb 2008, Johannes Sixt wrote:
> > @@ -1094,6 +1094,13 @@ remove-dashes:
> >
> >  ### Installation rules
> >
> > +ifeq ($(firstword $(subst /, ,$(template_dir))),..)
>
> How portable is "firstword"?  Would it not be better to use

How portable is "patsubst"? ;)

> ifneq ($(patsubst ../%,,$(template_dir)),)

This programming language is sort of write-only, so I don't know because I 
can't read it ;) If you have tested your version and it works and you have 
thought through all consequences (like how does it work if 
template_dir=/a/../b), why not?

-- Hannes