From: Johannes Sixt Date: Thu, 28 Feb 2008 21:04:20 GMT Subject: Re: [PATCH 27/40] Windows: Implement a custom spawnve(). Message-ID: <200802282204.20168.johannes.sixt@telecom.at> In-Reply-To: On Thursday 28 February 2008 16:36, Johannes Schindelin wrote: > On Wed, 27 Feb 2008, Johannes Sixt wrote: > > - cmd->pid = spawnvpe(_P_NOWAIT, cmd->argv[0], cmd->argv, (const char**)env); > > + cmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env); > > Should this not be "#define spawnvpe mingw_spanvpe" in git-compat-util.h > instead? No. We don't mimic the API of the original spawnvpe. Why obfuscate this fact? -- Hannes