From: Mike Hommey Date: Wed, 27 Feb 2008 20:05:51 GMT Subject: Re: [PATCH] Set proxy override with http_init() Message-ID: <20080227200551.GA6954@glandium.org> In-Reply-To: On Wed, Feb 27, 2008 at 02:59:38PM -0500, Daniel Barkalow wrote: > On Wed, 27 Feb 2008, Mike Hommey wrote: > > > In transport.c, proxy setting (the one from the remote conf) was set through > > curl_easy_setopt() call, while http.c already does the same with the > > http.proxy setting. We now just use this infrastructure instead, and make > > http_init() now take the proxy url as argument. > > > > At the same time, we make get_http_walker() take a proxy argument too, and > > pass it to http_init(), which makes remote defined proxy be used for more > > than get_refs_via_curl(). > > It's a good idea, but maybe http_init() (and the call chain leading up to > it) should take the struct remote, so that it can get anything else you > might also have there in the future? For that matter, is it intentional > that http-push ignore the proxy setting, which is equally available in > http-push, but not used? If so, it should probably get a comment. It is intentional, for the moment. I'll rework the patch to take the struct remote, and add a comment. Mike