From: Shawn O. Pearce Date: Mon, 25 Feb 2008 08:12:06 GMT Subject: Re: [PATCH 1/4] add generic, type aware object chain walker Message-ID: <20080225081206.GO8410@spearce.org> In-Reply-To: <20080225080653.GA20048@auto.tuwien.ac.at> Martin Koegler wrote: > On Mon, Feb 25, 2008 at 12:02:15AM -0800, Junio C Hamano wrote: > > mkoegler@auto.tuwien.ac.at (Martin Koegler) writes: > > > > > What about > > > #define OBJ_BAD -2 > > > > You mean "#define OBJ_ANY -2"? > > Yes. > > Should it go into cache.h or should it stay in fsck.h? I'd rather see this declared at the end of enum object_type, as essentially OBJ_MAX-1. But Nico may have a different opinion. As such it shouldn't need a numerical constant. We don't encode this constant into packfiles. -- Shawn.