From: Pierre Habouzit Date: Sun, 24 Feb 2008 08:49:58 GMT Subject: Re: [PATCH] parse-opt: bring PARSE_OPT_HIDDEN to git-rev-parse --parseopt Message-ID: <20080224084953.GA7623@artemis.madism.org> In-Reply-To: <7vbq66ycct.fsf@gitster.siamese.dyndns.org> On Sun, Feb 24, 2008 at 08:42:26AM +0000, Junio C Hamano wrote: > Pierre Habouzit writes: > > > I also made the parsing more extensible wrt new flags if needed. > > > > We should definitely write tests too. > > ... > > + case '*': > > + o->flags &= PARSE_OPT_HIDDEN; > > + break; > > I have a slight suspicion that this is not what you meant. > You probably meant either |= or perhaps ^=. oooh boy of course it's a |=... -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org