From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Sat, 23 Feb 2008 20:13:39 GMT
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Message-ID: <200802232113.40100.johannes.sixt@telecom.at>
In-Reply-To: <20080221000044.GB6429@coredump.intra.peff.net>

On Thursday 21 February 2008 01:00, Jeff King wrote:
> The fake-editor shell script invoked /bin/sh; normally this
> is fine, unless the /bin/sh doesn't meet our compatibility
> requirements, as is the case with Solaris. Specifically, the
> $() syntax used by fake-editor is not understood.
>
> Signed-off-by: Jeff King <peff@peff.net>
...
> -cat > fake-editor.sh <<\EOF
> -#!/bin/sh
> +echo "#!$SHELL" >fake-editor

Did you mean fake-editor.sh here?

> +cat >> fake-editor.sh <<\EOF
>  case "$1" in
>  */COMMIT_EDITMSG)
>  	test -z "$FAKE_COMMIT_MESSAGE" || echo "$FAKE_COMMIT_MESSAGE" > "$1"

-- Hannes