From: Jeff King <peff@peff.net>
Date: Sat, 23 Feb 2008 21:12:19 GMT
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Message-ID: <20080223211219.GA13178@coredump.intra.peff.net>
In-Reply-To: <7v1w732y97.fsf@gitster.siamese.dyndns.org>

On Sat, Feb 23, 2008 at 12:50:28PM -0800, Junio C Hamano wrote:

> > Gah, yes. Not sure how I was even able to run the test with that error.
> 
> Simple.  fake-editor.sh does not begin with #! anymore and exec
> causes /bin/sh to run, and your system happens to have a sane

I thought I tested it on the Solaris box with the broken shell, but
perhaps not.

> shell there.  If you used $SHELL not $SHELL_PATH and wrote to
> fake-editor.sh, you would have noticed that using $SHELL there
> was wrong as it would have said "#!bash" for you ;-)

Actually, my $SHELL is "/usr/local/bin/bash" on the box in question.

-Peff