From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 20 Feb 2008 00:13:39 GMT
Subject: Re: [PATCH] branch: optionally setup branch.*.merge from upstream local branches
Message-ID: <20080220001339.GA16574@steel.home>
In-Reply-To: <76718490802190549p549a34afo913efefebaf5fa97@mail.gmail.com>

Jay Soffian, Tue, Feb 19, 2008 14:49:17 +0100:
> On Feb 19, 2008 2:44 AM, Alex Riesen <raa.lkml@gmail.com> wrote:
> > Jay Soffian, Tue, Feb 19, 2008 03:07:12 +0100:
> > > +enum branch_track {
> > > +     BRANCH_TRACK_NEVER = 0,
> >
> > enums start at 0 anyway, don't they?
> 
> I don't know, but guys, give me a break on the enums already. What's
> the preferred syntax already because the existing code is not
> consistent:

Well, it could also mean that there is no rules yet, and you can
do the next sane thing of your choice.

> enum color_branch {
> 	COLOR_BRANCH_RESET = 0,
> 	COLOR_BRANCH_PLAIN = 1,
> 	COLOR_BRANCH_REMOTE = 2,
> 	COLOR_BRANCH_LOCAL = 3,
> 	COLOR_BRANCH_CURRENT = 4,
> };
>
> enum {
> 	TAGS_UNSET = 0,
> 	TAGS_DEFAULT = 1,
> 	TAGS_SET = 2
> };

Which is just as useless. It is not useful even for documentation,
as the verbatim values are not used anywere else (i.e. they are not
a part of file format, where they could stand out as the numbers
listed).

It looks like someone was just too paranoid or suffered a mental
damage from too long exposure to proprietary code.

> enum update_mode { BOTH = 0, WORKING_DIRECTORY, INDEX } *modes;
> 
> enum exist_status {
> 	index_nonexistent = 0,
> 	index_directory,
> 	index_gitdir,
> };
> 
> enum CAPABILITY {
> 	NOLOGIN = 0,
> 	UIDPLUS,
> 	LITERALPLUS,
> 	NAMESPACE,
> };

All the same...