From: Robert Schiele <rschiele@gmail.com>
Date: Sat, 16 Feb 2008 21:12:17 GMT
Subject: Re: Invalid html output repo.or.cz (alt-git.git)
Message-ID: <20080216211216.GL30676@schiele.dyndns.org>
In-Reply-To: <m3lk5kbry3.fsf@localhost.localdomain>

On Sat, Feb 16, 2008 at 11:52:42AM -0800, Jakub Narebski wrote:
> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> 
> > http://repo.or.cz/w/alt-git.git?a=shortlog
> > 
> > fails to load in my Seamonkey browser (Debian stable):
> > 
> > XML Parsing Error: not well-formed
> > Location: http://repo.or.cz/w/alt-git.git?a=shortlog
> > Line Number 561, Column 33:<td><i><span title="Uwe Kleine-K<span class="cntrl">\e</span>,Av<span class="cntrl">\e</span>(Bnig">Uwe Kleine ...</span></i></td>
> > --------------------------------^
> 
> It looks like gitweb uses esc_html instead of esc_param (or leaving it

Huh?  Isn't that the wrong escaping?  esc_param is for URLs not for XML
attributes in general, isn't it?

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."