From: Christian Couder Date: Sat, 16 Feb 2008 05:02:17 GMT Subject: [PATCH 6/6] diff.c: add "const" qualifier to "char *cmd" member of "struct ll_diff_driver" Message-ID: <20080216060217.c2ed3bb1.chriscool@tuxfamily.org> Also use "git_config_string" to simplify code where "cmd" is set. Signed-off-by: Christian Couder --- diff.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/diff.c b/diff.c index 5640cbf..173bb61 100644 --- a/diff.c +++ b/diff.c @@ -57,7 +57,7 @@ static int parse_diff_color_slot(const char *var, int ofs) static struct ll_diff_driver { const char *name; struct ll_diff_driver *next; - char *cmd; + const char *cmd; } *user_diff, **user_diff_tail; /* @@ -86,10 +86,7 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val user_diff_tail = &(drv->next); } - if (!value) - return config_error_nonbool(var); - drv->cmd = xstrdup(value); - return 0; + return git_config_string(&(drv->cmd), var, value); } /* -- 1.5.4.1.129.gf12af-dirty