From: Bruno Cesar Ribas <ribas@c3sl.ufpr.br>
Date: Sun, 10 Feb 2008 02:46:11 GMT
Subject: Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list
Message-ID: <20080210024611.GA31577@c3sl.ufpr.br>
In-Reply-To: <200802081015.39707.jnareb@gmail.com>

On Fri, Feb 08, 2008 at 10:15:39AM +0100, Jakub Narebski wrote:
> Junio C Hamano wrote:
> > Bruno Cesar Ribas <ribas@c3sl.ufpr.br> writes:
> >> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:
> >>> Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> >>>
> >>><snip> 
> >>>
> >>> Good catch (although it wasn't actually a bug).
> >>
> >> Not a bug but makes the code cleaner =)
> > 
> > I think I saw very similar 's|projectroot/$path|$git_dir|' patch
> > recently.  If there are more of the same, I'd rather see all of
> > them in a single patch.
> 
> That's all that it is. Those patches are about places where we read
> file inside repo or get repo config, and there are only two places now: 
> description and cloneurl/URL list.

And (if added) at the owner's place ;)

> 
> -- 
> Jakub Narebski
> Poland

-- 
Bruno Ribas - ribas@c3sl.ufpr.br
http://web.inf.ufpr.br/ribas
C3SL: http://www.c3sl.ufpr.br