From: J. Bruce Fields <bfields@fieldses.org>
Date: Sat, 09 Feb 2008 20:04:35 GMT
Subject: Re: [PATCH] Add gitattributes file making whitespace checking pickier
Message-ID: <20080209200435.GA8919@fieldses.org>
In-Reply-To: <m3abm9hqix.fsf@localhost.localdomain>

On Sat, Feb 09, 2008 at 11:36:31AM -0800, Jakub Narebski wrote:
> "J. Bruce Fields" <bfields@fieldses.org> writes:
> 
> >  gitweb/gitweb.perl                                  |  566 ++--
> >  index-pack.c                                        |   30 
> 
> gitweb (at my insistence) uses tabs for indent, but spaces for align,
> so that the layout is [roughly] preserved independently of the tab
> size. IMHO it is superior style, but much harder to check
> algorithmically (although I send some sketch of idea how to check that
> at least for aligned commands). That is why there is such a big change.
> 
> I'd rather have real bugfixes, real documentation improvements, new
> features instead of such bikeshedding.  If someone is making a change
> somewhere, he/she can fix the whitespace in the neighbourhood.

I agree completely.  Did I suggest otherwise?

--b.