From: Bruno Cesar Ribas <ribas@c3sl.ufpr.br>
Date: Fri, 08 Feb 2008 13:53:27 GMT
Subject: Re: [PATCH] gitweb: Use the config file to set repository owner's name.
Message-ID: <20080208135327.GC30264@c3sl.ufpr.br>
In-Reply-To: <m3myqbhg4o.fsf@localhost.localdomain>

On Fri, Feb 08, 2008 at 02:55:33AM -0800, Jakub Narebski wrote:
> Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> 
><snip> 
> First, I think the empty lines added are not needed.

I made those empty lines because original code had same empty lines above, I
just let it to have same pattern, but I can remove. Should I remove?! I'll
resend without it, and with $git_dir set.
> 
> Second, git_get_project_config() subroutine _REQUIRES_ for $git_dir to
> be set. So you have to set $git_dir before checking repo config; then
> you can reuse $git_dir in checking file owner.
> 
> -- 
> Jakub Narebski
> Poland
> ShadeHawk on #git

-- 
Bruno Ribas - ribas@c3sl.ufpr.br
http://web.inf.ufpr.br/ribas
C3SL: http://www.c3sl.ufpr.br