From: Jakub Narebski Date: Fri, 08 Feb 2008 09:15:39 GMT Subject: Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list Message-ID: <200802081015.39707.jnareb@gmail.com> In-Reply-To: <7vbq6sm0j3.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > Bruno Cesar Ribas writes: >> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote: >>> Bruno Ribas writes: >>> >>> >>> >>> Good catch (although it wasn't actually a bug). >> >> Not a bug but makes the code cleaner =) > > I think I saw very similar 's|projectroot/$path|$git_dir|' patch > recently. If there are more of the same, I'd rather see all of > them in a single patch. That's all that it is. Those patches are about places where we read file inside repo or get repo config, and there are only two places now: description and cloneurl/URL list. -- Jakub Narebski Poland