From: Jakub Narebski Date: Wed, 06 Feb 2008 21:22:37 GMT Subject: Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view Message-ID: <200802062222.38691.jnareb@gmail.com> In-Reply-To: <7vd4r9vmnd.fsf@gitster.siamese.dyndns.org> Dnia środa 6. lutego 2008 21:46, Junio C Hamano napisał: > Jakub Narebski writes: > > > I think that with the improved commit message the reason for this > > change is more obvious, and it is a go. > > Thanks. Looks good. Errr... in the commit message >> First, feed entries have whatchanged-like list of files which were >> modified in a commit, so 'commitdiff' view more naturally reflects >> feed entry (in more naturally alternate / extended version of a feed >> item). Second, this way the patches are shown directly and code review >> is done more easily via watching feeds. "... (in more naturally ..." should be "... (is more naturally ...". Unfortunately this kind of errors are hard to catch (and spellchecker would not help any) -- Jakub Narebski Poland