From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Tue, 05 Feb 2008 21:47:47 GMT
Subject: Re: [EGIT PATCH Series] Cleanups and javadocs
Message-ID: <200802052247.47744.robin.rosenberg@dewire.com>
In-Reply-To: <47A87C26.2070307@intelinet.com.br>

tisdagen den 5 februari 2008 skrev Roger C. Soares:
> 
> Robin Rosenberg escreveu:
> > Here is a number of small enhancements that reduce the number of warnings
> > displayed and raises the standard on comments. We now get javadoc comments
> > on all public and protected methods which hopefully will make it slighly
> > easier to get on the train for those interested in helping out with Egit/Jgit.
> >
> > Disabling the else-warning is probably fairly uncontroversial. Disabling some
> > warning about boxing/unboxing of integers might be as might be requiring
> > javadoc comments.
> >
> >   
> Hi Robin,
> 
> [2, 3, 5 and 6] - looks fine to me.
Thanks for looking.

> [1] - What about something like "nothing to be done here" and/or 
> "implementing interface method"?
"Empty" is a marker that the block is *intentionally* empty, which
is the point here.

> [4] - Some typos:
Thanks

-- robin