From: Jeff King <peff@peff.net>
Date: Thu, 31 Jan 2008 10:42:56 GMT
Subject: Re: [PATCH] gitignore(5): Allow "foo/" in ignore list to match directory "foo"
Message-ID: <20080131104256.GF25546@coredump.intra.peff.net>
In-Reply-To: <7vfxwecmfe.fsf@gitster.siamese.dyndns.org>

On Thu, Jan 31, 2008 at 02:35:33AM -0800, Junio C Hamano wrote:

> Without "foo/", you do not have to pay the price, so I think
> that is a sane optimization, but at the same time it would make
> it worse if "foo/" is actually used.  excluded_1() is called for
> the same pathname from a loop to check for a match and you would
> end up running lstat(2) three times (once each for EXC_CMDL,
> EXC_DIRS and EXC_FILE).
> 
> But maybe people who want "foo/" deserve it.  I dunno.

Ah, I didn't look at it that closely.

To do the laziness right, I think you would need to pass a pointer to
the dtype around, and just fill it in the first time it is needed.

-Peff