From: Robert Schiele Date: Thu, 24 Jan 2008 21:58:03 GMT Subject: Re: [PATCH] some systems don't have (and need) sys/select.h Message-ID: <20080124215803.GN30676@schiele.dyndns.org> In-Reply-To: <7vk5ly9b51.fsf@gitster.siamese.dyndns.org> On Thu, Jan 24, 2008 at 01:17:14PM -0800, Junio C Hamano wrote: > Robert Schiele writes: > > > The select stuff is already in sys/time.h on on some systems like HP-UX > > thus we should not include sys/select.h in that case. > > > > Signed-off-by: Robert Schiele > > The patch looks good. I'd rather try to be a bit more helpful > to people who want to port git to their system that is not > HP-UX, though. > > How about wording it like this? > > Subject: pre-POSIX.1-2001 systems do not have > > POSIX.1-2001 has declaration of select(2) in , but > in previous version of SUS, it is declared in , > which is already included in git-compat-util.h. > > This introduces NO_SYS_SELECT_H macro in the Makefile to be set > on older systems, to skip inclusion of that does > not exist on them. > > We could check _POSIX_VERSION with 200112L and do this > automatically, but earlier it was reported that the approach > does not work well on some vintage of HP-UX. Other systems may > get _POSIX_VERSION itself wrong. At least for now, this manual > configuration is safer. I have no strong opinion on the wording. Sounds reasonable to me. Robert -- Robert Schiele Dipl.-Wirtsch.informatiker mailto:rschiele@gmail.com "Quidquid latine dictum sit, altum sonatur."