From: Eric Wong Date: Mon, 21 Jan 2008 22:48:28 GMT Subject: Re: [PATCH] Let "git svn" run "git gc --auto" occasionally Message-ID: <20080121224818.GA8872@untitled> In-Reply-To: <7vlk6k8fyp.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > Karl Hasselström writes: > > > On 2008-01-19 19:37:37 -0800, Eric Wong wrote: > > > >> Harvey Harrison wrote: > >> > >> > I found 100 was a bit too low when doing some large repos, I've > >> > been using 1000. I'd argue that --repack=1000 should be done by > >> > default. > >> > >> I've found 100 for repack too low in the past, too, which is why > >> repack defaults to 1000 if no number is specified. I think it should > >> hold for gc --auto, too. > > > > OK, I'll change it. But remember, gc --auto doesn't do _anything_ > > unless it's deemed necessary, so it should behave much better than > > just plain repack. In theory at least. > > Careful. I made the same mistake and it had to be corrected with > e0cd252eb0ba6453acd64762625b004aa4cc162b. > > I think defaulting to --repack=1000 is a sane first step and you > guys already have most code for it so that is a very safe thing. > > Switching to "gc --auto" can be done early post 1.5.4, right? Sorry for the latency[1], ack on both of Karl's patches for post-1.5.4. Here's a conservative change for 1.5.4 (not at all tested): From dbccd8081c6422569a9ca1211e27f56a24fdf3f3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 21 Jan 2008 14:37:41 -0800 Subject: [PATCH] git-svn: default to repacking every 1000 commits This should reduce disk space usage when doing large imports. We'll be switching to "gc --auto" post-1.5.4 to handle repacking for us. Signed-off-by: Eric Wong --- git-svn.perl | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 9f2b587..12745d5 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1408,11 +1408,9 @@ sub read_all_remotes { } sub init_vars { - if (defined $_repack) { - $_repack = 1000 if ($_repack <= 0); - $_repack_nr = $_repack; - $_repack_flags ||= '-d'; - } + $_repack = 1000 unless (defined $_repack && $_repack > 0); + $_repack_nr = $_repack; + $_repack_flags ||= '-d'; } sub verify_remotes_sanity { -- Eric Wong [1] - I've been busy with other things and will also be traveling this week, too.