From: Karl Hasselström <kha@treskal.com>
Date: Sat, 19 Jan 2008 12:35:57 GMT
Subject: Re: git-svn should default to --repack
Message-ID: <20080119123557.GA30778@diana.vm.bytemark.co.uk>
In-Reply-To: <7vfxwudftz.fsf@gitster.siamese.dyndns.org>

On 2008-01-18 12:44:08 -0800, Junio C Hamano wrote:

> Karl Hasselström <kha@treskal.com> writes:
>
> > I believe so too. And nowadays there's "git gc --auto", which was
> > made for occasions such as this, so it should be a breeze to
> > implement. The overhead might be low enough that it can be called
> > after _every_ imported revision.
>
> Careful. I made the same mistake and it had to be corrected with
> e0cd252eb0ba6453acd64762625b004aa4cc162b.
>
> "gc --auto" after every 1000 or so feels like a good default and I
> would agree that would be a real fix to a real usability bug.

I think 1000 might be too high; considering that (at least in my
experience) it takes on the order of 250-500 ms to import a commit,
the gc --auto overhead of maybe 10 ms isn't so bad.

A good compromise might be to run gc --auto after every 10-100
commits, _and_ when the import is done.

However, if gc --auto always takes a lot of time without accomplishing
anything in the presence of too many unreachable loose objects it
might not be a good idea to run it at all, since the use of git-svn
involves frequent rebasing.

> Patches?

Just hot air and noise for now from my end. Sorry.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle