From: Charles Bailey <charles@hashpling.org>
Date: Thu, 17 Jan 2008 13:07:40 GMT
Subject: Re: Be more careful about updating refs
Message-ID: <20080117130740.GA30090@hashpling.org>
In-Reply-To: <alpine.LSU.1.00.0801171256280.17650@racer.site>

On Thu, Jan 17, 2008 at 12:58:07PM +0000, Johannes Schindelin wrote:
> 
> Just a wild guess... Could it be that the mmap() happened before contents 
> were written to that fd?  The faked mmap() is just a malloc() && pread(), 
> and would thus miss out on changes written after the mmap() call.

This would be my guess too.  As far as I can tell fast-import is
creating objects directly in a packfile.  I'm guessing here, but the
new checking code is probably being triggered to check (for example)
the parent ref for commits that fast-import is creating and the check
only works if mmap can successfully examine objects in the
still-being-written packfile.