From: Pierre Habouzit Date: Thu, 10 Jan 2008 18:18:38 GMT Subject: Re: [PATCH] bundle, fast-import: detect write failure Message-ID: <20080110181838.GC27808@artemis.madism.org> In-Reply-To: <87lk6xftdn.fsf@rho.meyering.net> On Thu, Jan 10, 2008 at 06:05:56PM +0000, Jim Meyering wrote: > Pierre Habouzit wrote: > .... > >> On the other hand, if that write failure is truly ignorable, > >> a mindless minimalist :-) might argue that it's best just to > >> omit the syscall. > > > > And leak a file descriptor :) > > Not that mindless. > The *write* syscall, not the close. > I would never suggest eliminating the close. oh *oops* > - > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html