From: Luciano Rocha Date: Thu, 20 Dec 2007 12:06:01 GMT Subject: Re: [PATCH v2] builtin-tag.c: allow arguments in $EDITOR Message-ID: <20071220120601.GA15290@bit.office.eurotux.com> In-Reply-To: On Thu, Dec 20, 2007 at 12:58:59PM +0100, Johannes Schindelin wrote: > Hi, > > On Thu, 20 Dec 2007, Luciano Rocha wrote: > > > The previous sh version of git-commit evaluated the value of the defined > > editor, thus allowing arguments. > > > > Make the builtin version work the same, by adding an explicit check for > > arguments in the editor command, and extract them to an additional > > argument. > > Anything wrong with that patch? > > http://article.gmane.org/gmane.comp.version-control.git/68444 No, I just missed it in the mailing list. That patch also supports any number of whitespace/arguments. -- Luciano Rocha Eurotux Informática, S.A.