From: Pierre Habouzit <madcoder@debian.org>
Date: Mon, 17 Dec 2007 19:03:28 GMT
Subject: Re: [PATCH 7/7] git-tag: fix -l switch handling regression.
Message-ID: <20071217190328.GF22554@artemis.madism.org>
In-Reply-To: <20071217185652.GE22554@artemis.madism.org>

On Mon, Dec 17, 2007 at 06:56:52PM +0000, Pierre Habouzit wrote:
>   And I managed to resend the broken version, hurray myself.
> 
> > +		OPT_INTEGER('l', NULL, &list, "list tag names"),
>                 OPT_BOOLEAN
> 
> 
> 
> Both these last minute fixes are applied to my public git.git.
> 
> Let's now write 1000 times: I will run the test-suite before I send
> patches, I will rune the test-suite before I send patches, …

  oh and t7004 doesn't pass anymore because of the:

  git -n xxx -l or git -n "" -l tests. If we really want to allow that
(but it _REALLY_ feels wrong to me) we have to make '-l' a callback that
groks non integers as 0. Else the test also has to be fixed, I'm not
sure what to do here.


-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org