From: Pierre Habouzit Date: Mon, 17 Dec 2007 18:54:16 GMT Subject: Re: [PATCH 1/7] parse-options: Make callbacks take flags instead of boolean `unset` Message-ID: <20071217185416.GD22554@artemis.madism.org> In-Reply-To: <1197915797-30679-2-git-send-email-madcoder@debian.org> And of course here is the MadBug #1, to be squashed: --- builtin-rev-parse.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-rev-parse.c b/builtin-rev-parse.c index 20d1789..3e8ee62 100644 --- a/builtin-rev-parse.c +++ b/builtin-rev-parse.c @@ -210,10 +210,10 @@ static int try_difference(const char *arg) return 0; } -static int parseopt_dump(const struct option *o, const char *arg, int unset) +static int parseopt_dump(const struct option *o, const char *arg, int flags) { struct strbuf *parsed = o->value; - if (unset) + if (flags & PARSE_OPT_UNSET) strbuf_addf(parsed, " --no-%s", o->long_name); else if (o->short_name) strbuf_addf(parsed, " -%c", o->short_name); -- 1.5.4.rc0.1151.g102b0