From: Jeff King <peff@peff.net>
Date: Sat, 15 Dec 2007 10:09:50 GMT
Subject: Re: git-cvsexportcommit fails for huge commits
Message-ID: <20071215100950.GB1692@coredump.intra.peff.net>
In-Reply-To: <200712141447.05039.robin.rosenberg.lists@dewire.com>

On Fri, Dec 14, 2007 at 02:47:03PM +0100, Robin Rosenberg wrote:

> > So here is a cleaned up patch. It bumps the maximum size to 64kB, adds
> > scalar support (nobody uses it, but it makes sense for the interface to
> > match that of safe_pipe_capture -- I am even tempted to just replace
> > safe_pipe_capture entirely and convert the few other callers), and
> > cleans up the unused safe_pipe_capture_blob.
> 
> Wouldn't using the POSIX::ARG_MAX constant work?

It does seem to produce sensible results. Does it work reasonably on
Windows?

Note that it would also need to be ARG_MAX - slop, where slop accounts
for the environment (which maybe we can get accurately by counting the
keys and values of %ENV, adding NUL terminators?).

-Peff