From: Pierre Habouzit Date: Wed, 12 Dec 2007 20:02:11 GMT Subject: Re: [PATCH] Don't cache DESTDIR in perl/perl.mak. Message-ID: <20071212200211.GB1060@artemis.madism.org> In-Reply-To: <20071212180050.GA18980@untitled> On Wed, Dec 12, 2007 at 06:01:48PM +0000, Eric Wong wrote: > Junio C Hamano wrote: > > Hmph. That's reverting this: > > > > commit 4c5cf8c44ce06a79da5bafd4a92e6d6f598cea2e > > Author: Eric Wong > > Date: Sun Aug 13 04:13:25 2006 -0700 > > > > pass DESTDIR to the generated perl/Makefile > > > > Makes life for binary packagers easier, as the Perl modules will > > be installed inside DESTDIR. > > > > Signed-off-by: Eric Wong > > Signed-off-by: Junio C Hamano > > > > Eric, care to comment? > > I used to make a statically linked binary package for working on an > ancient box that didn't have a lot of libraries I wanted, and I probably > just called `make install' into DESTDIR as a single step without calling > `make' alone without DESTDIR argument, or I had DESTDIR set in > config.mak Actually this fact generated a bug in debian packaging because git is built then installed twice in different DESTDIRS, then parts of the install is pruned (the two installs are arch-dependant and arch-independant files install so it's a very good reason in term of packaging). The fact that perl.mak caches the DESTDIR make it install things in the wrong place because it doesn't honour make DESTDIR=foo install and always use the cached value instead, which is wrong. I think Gerrit won't care if it's cached or not, he just cares that it still honours environment if present. -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org