From: Mike Hommey <mh@glandium.org>
Date: Sun, 09 Dec 2007 18:14:37 GMT
Subject: Re: [PATCH] git-send-email.perl: Really add angle brackets to In-Reply-To if necessary
Message-ID: <20071209181437.GA9211@glandium.org>
In-Reply-To: <7v63z7rb87.fsf@gitster.siamese.dyndns.org>

On Sun, Dec 09, 2007 at 10:09:44AM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
> >  git-send-email.perl |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > index 76baa8e..1434eb2 100755
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -367,10 +367,11 @@ if ($thread && !defined $initial_reply_to && $prompting) {
> >  	} while (!defined $_);
> >  
> >  	$initial_reply_to = $_;
> > -	$initial_reply_to =~ s/^\s+<?/</;
> > -	$initial_reply_to =~ s/>?\s+$/>/;
> >  }
> 
> I wonder what the original rationale for these \s+ was.

I'd say copy/paste:
-       $initial_reply_to =~ s/(^\s+|\s+$)//g;
+       $initial_reply_to =~ s/^\s+<?/</;
+       $initial_reply_to =~ s/>?\s+$/>/;

Mike