From: Jakub Narebski Date: Fri, 07 Dec 2007 00:11:21 GMT Subject: Re: [PATCH] Silence iconv warnings on Leopard Message-ID: <200712070111.23283.jnareb@gmail.com> In-Reply-To: <985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com> On Fri, 7 Dec 2007, Blake Ramsdell wrote: > On Dec 6, 2007 11:07 AM, Wincent Colaiuta wrote: >> Apple ships a newer version of iconv with Leopard (Mac OS X 10.5/Darwin >> 9). Ensure that OLD_ICONV is not set on any version of Darwin in the >> 9.x series; this should be good for at least a couple of years, when >> Darwin 10 comes out and we can invert the sense of the test to >> specifically check for Darwin 7 or 8. >> A more sophisticated and robust check is possible for those who use >> autoconf, but not everybody does that. > > I did make a patch for configure.ac that does this. If it's > interesting, I'll send it along. I would be interested, as I tried to make a patch to configure.ac which does that. The problem is that it should be check that tests for compile time _warnings_; my solution was to use '-Werror' flag to make warning into error, and AC_COMPILE_IFELSE, but this might be gcc only solution. Message-ID: <1196895948-25115-1-git-send-email-jnareb@gmail.com> http://permalink.gmane.org/gmane.comp.version-control.git/67209 So please send it. Thanks in advance -- Jakub Narebski Poland