From: Jeff King <peff@peff.net>
Date: Sun, 02 Dec 2007 05:40:30 GMT
Subject: Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created
Message-ID: <20071202054030.GA393@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0712012238510.27959@racer.site>

On Sat, Dec 01, 2007 at 10:41:47PM +0000, Johannes Schindelin wrote:

> Basically, I ran a test case in which the shell script was different from 
> the builtin version, and this was the patch that fixed it for me.
> 
> Maybe it should have been
> 
> 	if (log_tree_commit(&rev, commit))
> 		printf("\n");
> 
> at the end of print_summary() instead.  Can you try if that fixes it for 
> you?

No, it doesn't, unless you meant "if (!log_tree_commit(...". Of course,
I can't get log_tree_commit to return anything but true anyway (either
log_tree_diff shows something, or since we have set always_show_header,
we end up calling show_log).

It would be helpful if you could remember the test case, but perhaps
that is not an option at this point.

-Peff