From: Jeff King Date: Wed, 28 Nov 2007 18:55:04 GMT Subject: Re: git-cvsimport bug Message-ID: <20071128185504.GA11236@coredump.intra.peff.net> In-Reply-To: <20071128165746.GC20308@coredump.intra.peff.net> On Wed, Nov 28, 2007 at 11:57:46AM -0500, Jeff King wrote: > Some of git-cvsimport is quite old, and it accesses the ref files > directly. It should be fairly easy to fix; I will post a patch in a few > minutes. The patch series is: 1/3: Add basic cvsimport tests We had no tests before, so this at least gives a sanity check. I added a t9600 series, though perhaps the cvs-related tests (cvsserver and exportcommit) should collapse to a single t9[0-9]* series. 2/3: cvsimport: use show-ref to support packed refs This fix is hopefully obvious, and the included test fails without it (and this should probably fix Emanuele's problem). 3/3: cvsimport: miscellaneous packed-ref fixes This fixes all of the packed-ref problem spots I could find. However, I have no tests that show the problems or that verify that the fixes are sane. So apply with caution. Probably cvsimport would benefit greatly from a conversion to Git.pm, but that is likely to involve a lot of rewriting, and I have neither the time nor the inclination for that right now. -Peff