From: Jeff King <peff@peff.net>
Date: Wed, 28 Nov 2007 16:10:34 GMT
Subject: Re: [PATCH] Allow update hooks to update refs on their own
Message-ID: <20071128161033.GA20308@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0711272143470.5349@iabervon.org>

On Tue, Nov 27, 2007 at 10:25:32PM -0500, Daniel Barkalow wrote:

> > It would of course be better if git-push could notice that it needs
> > to do an actual fetch. I think it'd be sufficient to transmit the
> > final remote ref SHA1 back to git-push, and if it doesn't match what
> > was pushed, that's a sign that a fetch is needed. But that change
> > wouldn't be mutually exclusive with this patch, I believe.
> 
> Couldn't you do this with a status message? ("ok <refname> changed by 
> hook" or something.)

Having just touched this code, I believe the answer is yes. receive-pack
has always sent just "ok <refname>\n", so we could start interpreting
anything after the <refname> bit freely (I think "ok <refname>
changed-to <hash>" is even more informative, but perhaps not useful
given that the sender probably doesn't have that commit object).

-Peff