From: Karl Hasselström <kha@treskal.com>
Date: Mon, 26 Nov 2007 10:44:48 GMT
Subject: Re: [StGit PATCH 07/10] Teach the new infrastructure about the index and worktree
Message-ID: <20071126104448.GA3936@diana.vm.bytemark.co.uk>
In-Reply-To: <874pf9bd11.fsf@lysator.liu.se>

On 2007-11-26 09:56:42 +0100, David Kågedal wrote:

> Karl Hasselström <kha@treskal.com> writes:
>
> > --- a/stgit/lib/git.py
> > +++ b/stgit/lib/git.py
> > @@ -95,6 +95,8 @@ class Commitdata(Repr):
> >          return type(self)(committer = committer, defaults = self)
> >      def set_message(self, message):
> >          return type(self)(message = message, defaults = self)
> > +    def is_empty(self):
> > +        return self.tree == self.parent.data.tree
> >      def __str__(self):
> >          if self.tree == None:
> >              tree = None
>
> But a Commitdata describes a Git commit, right? And not an StGit
> patch.

Yes.

> So what does it mean to say that a commit is empty? I could just as
> well mean that the tree is the null tree. I think I would have
> called this "is_nochange" or something.

Good point.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle