From: Jeff King Date: Wed, 21 Nov 2007 07:33:32 GMT Subject: Re: [PATCH 1/2] send-pack: cluster ref status reporting Message-ID: <20071121073332.GA10244@sigill.intra.peff.net> In-Reply-To: <7v1wakhxh4.fsf@gitster.siamese.dyndns.org> On Tue, Nov 20, 2007 at 11:24:55PM -0800, Junio C Hamano wrote: > > + case REF_STATUS_REMOTE_REJECT: > > + print_ref_status('!', "[remote rejected]", ref, > > + ref->deletion ? ref->peer_ref : NULL, > > + ref->remote_status); > > + break; > > + case REF_STATUS_EXPECTING_REPORT: > > + print_ref_status('!', "[remote failure]", ref, > > + ref->deletion ? ref->peer_ref : NULL, > > + "remote failed to report status"); > > + break; > > Eh,... in ref->deletion mode, the peer_ref is... Gah, sorry. This crept in because I based it on the previous, broken version of the other patch series which had the same problem (and obviously this chunk is just a pure code move + reindent). But pretend like it was competently prepared and give your comments on the idea. ;) -Peff